Hello TengYao, just one last minor comment. The KIP refers in multiple places to bumping the heartbeat RPC from version 0 to version 1. We should update that given that the RPC is already in version 1.
With that I'm +1 (binding) Thanks! Lianet On Thu, Oct 3, 2024 at 5:01 AM David Jacot <dja...@confluent.io.invalid> wrote: > +1 (binding) > > Thanks for the KIP! > > Best, > David > > On Thu, Oct 3, 2024 at 10:49 AM TengYao Chi <kiting...@gmail.com> wrote: > > > Hello everyone, > > As the vote has been pending for two weeks, I would like to push it > > manually. > > Thank you for your attention. > > > > Best, > > TengYao > > > > Chris Egerton <fearthecel...@gmail.com> 於 2024年9月19日 週四 上午1:42寫道： > > > > > Thanks for the KIP! +1 (binding) > > > > > > On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield < > > > andrew_schofield_j...@outlook.com> wrote: > > > > > > > +1 (non-binding) > > > > > > > > ________________________________________ > > > > From: 吳岱儒 <tjwu1...@gmail.com> > > > > Sent: 17 September 2024 04:24 > > > > To: dev@kafka.apache.org <dev@kafka.apache.org> > > > > Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the > > > > ConsumerGroupHeartbeat RPC > > > > > > > > +1 (non-binding) > > > > > > > > Best, > > > > TaiJuWu > > > > > > > > Chia-Ping Tsai <chia7...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道： > > > > > > > > > +1 (binding) > > > > > > > > > > thanks for reaching out to the corner case. > > > > > > > > > > Best, > > > > > Chia-Ping > > > > > > > > > > Kirk True <k...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道： > > > > > > > > > > > Hi TengYao, > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Thanks for all the hard work with the tricky edge cases :) > > > > > > > > > > > > Kirk > > > > > > > > > > > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <kiting...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > Based on our discussion > > > > > > > < > > https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371> > > > > > > > regarding KIP-1082 < > https://cwiki.apache.org/confluence/x/XBDOEg > > >, > > > I > > > > > > > believe this KIP is now ready for a vote. > > > > > > > > > > > > > > Sincerely, > > > > > > > TengYao > > > > > > > > > > > > > > > > > > > > > > > > > > >
