+1 (binding) from me Justine
On Mon, Sep 16, 2024 at 7:36 PM TengYao Chi <kiting...@gmail.com> wrote: > Hi Kirk > Thanks for pointing out. I have updated the description of KAFKA-17087. > > Sincerely, > TengYao > > Kirk True <k...@kirktrue.pro> 於 2024年9月16日 週一 下午11:45寫道： > > > Hi TengYao, > > > > +1 (non-binding). > > > > Using KAFKA-17087 to track the actual removal in 5.0 is going to help > this > > not fall through the cracks. One minor point is that the description for > > the Jira states that "we should deprecate it in 3.9 and then remove it > from > > 4.0” which should be "we should deprecate it in 4.0 and then remove it > from > > 5.0" > > > > Thanks! > > > > > On Sep 16, 2024, at 6:54 AM, Lianet M. <liane...@gmail.com> wrote: > > > > > > Thanks for the update! Looks good to me now. > > > > > > +1 (binding) > > > > > > Cheers, > > > > > > Lianet > > > > > > On Mon, Sep 16, 2024 at 9:31 AM TengYao Chi <kiting...@gmail.com> > wrote: > > > > > >> Hi Lianet, > > >> > > >> Thanks for comment. > > >> It is very helpful and I have applied it to the content of this KIP. > > >> Please take a look. > > >> > > >> Sincerely, > > >> TengYao > > >> > > >> Lianet M. <liane...@gmail.com> 於 2024年9月16日 週一 下午7:16寫道： > > >> > > >>> Hello TengYao. > > >>> > > >>> Thanks for the KIP, nice cleanup. Just one question left. I wonder > how > > we > > >>> make sure that we don't just bring in this KIP, deprecate the arg and > > >>> forget about it?. First we could maybe mention in the KIP that is > with > > >> the > > >>> intention of removing the option in 5.0 (just for reference), and > also > > >>> create and include here the jira for it already (maybe in the > > >>> "Compatibility, Deprecation, and Migration Plan" section)? > > >>> > > >>> Thanks! > > >>> > > >>> Lianet > > >>> > > >>> On Mon, Sep 16, 2024 at 1:01 AM TengYao Chi <kiting...@gmail.com> > > wrote: > > >>> > > >>>> Hello everyone, > > >>>> I hope this message finds you well. > > >>>> As the vote has been pending for two weeks, I would like to push it > > >>>> manually. > > >>>> > > >>>> Thank you for your attention. > > >>>> > > >>>> Sincerely, > > >>>> TengYao > > >>>> > > >>>> Andrew Schofield <andrew_schofi...@live.com> 於 2024年8月27日 週二 > > >> 下午10:20寫道： > > >>>> > > >>>>> Thanks for the KIP. > > >>>>> > > >>>>> +1 (non-binding) > > >>>>> > > >>>>> Andrew > > >>>>> > > >>>>>> On 27 Aug 2024, at 10:31, Federico Valeri <fedeval...@gmail.com> > > >>>> wrote: > > >>>>>> > > >>>>>> +1 non binding > > >>>>>> > > >>>>>> Should we also create a Jira to track future removal? > > >>>>>> > > >>>>>> On Tue, Aug 27, 2024 at 11:02 AM Chia-Ping Tsai < > > >> chia7...@apache.org > > >>>> > > >>>>> wrote: > > >>>>>>> > > >>>>>>> +1 (binding) > > >>>>>>> > > >>>>>>> On 2024/08/27 06:15:57 TengYao Chi wrote: > > >>>>>>>> Hi everyone, > > >>>>>>>> > > >>>>>>>> The discussion > > >>>>>>>> < > > >> https://lists.apache.org/thread/p4nz31zh6lokw4c1nld9dm0740oxw98j> > > >>>> of > > >>>>>>>> KIP-1079 > > >>>>>>>> < > > >>>>> > > >>>> > > >>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1079:+Deprecate+%60delete-config%60+of+TopicCommand > > >>>>>> > > >>>>>>>> has > > >>>>>>>> been silent for a long time, I believe this KIP is now ready for > > >> a > > >>>>> vote. > > >>>>>>>> > > >>>>>>>> Sincerely, > > >>>>>>>> TengYao > > >>>>>>>> > > >>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > >
