> On Aug. 20, 2014, 1:31 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala, line 7 > > <https://reviews.apache.org/r/24856/diff/1/?file=664458#file664458line7> > > > > We should probably just grab this from TxRequestTypes in the api > > package for consistency.
Sure. Previously I thought ConsoleConsumer is separated from core package, but it is not. Please see updated patch. > On Aug. 20, 2014, 1:31 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ConsumerTransactionBuffer.scala, line 23 > > <https://reviews.apache.org/r/24856/diff/1/?file=664458#file664458line23> > > > > I guess we can just call it transaction buffer. Also, I'm assuming this > > is somewhat temporary. i.e., ideally we would want to have a nice trait for > > this and be able to specify features such as spilling to disk, etc. Yes, this is a very simple prototype. I use it as a proof-of-concept for buffered consumer logic, and to provide skeleton code on which we can extend in the future patch. The implementation of this TransactionBuffer class is critical for consumer performance. It will take time to carefully implment, test, and tune this class. I probably can work on it after internship. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/#review51050 ----------------------------------------------------------- On Aug. 20, 2014, 4:10 a.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24856/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 4:10 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1601 > https://issues.apache.org/jira/browse/KAFKA-1601 > > > Repository: kafka > > > Description > ------- > > KAFKA-1601; ConsoleConsumer/SimpleConsumerPerformance should be > transaction-aware > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/TransactionBuffer.scala PRE-CREATION > core/src/main/scala/kafka/message/MessageAndMetadata.scala > d693abc620aef7030f29f915604c5e172d60da0d > core/src/main/scala/kafka/tools/ConsoleConsumer.scala > 323fc8566d974acc4e5c7d7c2a065794f3b5df4a > core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala > 7602b8d705970a5dab49ed36d117346a960701ac > > Diff: https://reviews.apache.org/r/24856/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
