> These variables are used in `TopologyConfig`, so I think that they can be public if they are presented the same meaning in both `TopologyConfig` and `StreamConfig`.
they can be package-private, right? Best, Chia-Ping 黃竣陽 <s7133...@gmail.com> 於 2024年8月29日 週四 上午11:53寫道： > Hi Chia-Ping, > > These variables are used in `TopologyConfig`, so I think that they can be > public if they are presented the same meaning in both `TopologyConfig` and > `StreamConfig`. > > Best regards, > Jiunn Yang > > > Chia-Ping Tsai <chia7...@gmail.com> 於 2024年8月29日 上午11:38 寫道： > > > > hi Jiunn > > > > The following DOC-related variables are public too. Should they be > included? > > > > BUFFERED_RECORDS_PER_PARTITION_DOC > > CACHE_MAX_BYTES_BUFFERING_DOC > > DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_DOC > > DEFAULT_TIMESTAMP_EXTRACTOR_CLASS_DOC > > MAX_TASK_IDLE_MS_DOC > > STATESTORE_CACHE_MAX_BYTES_DOC > > TASK_TIMEOUT_MS_DOC > > > > Best, > > Chia-Ping > > > > Luke Chen <show...@gmail.com> 於 2024年8月29日 週四 上午11:26寫道： > > > >> Hi Jiunn, > >> > >> Thanks for the KIP. > >> > >> In the motivation section: > >> "The overly large scope of these variables can cause development > issues." > >> > >> I can't see why a "doc description variable" will cause any development > >> issue. > >> Could you explain more clearly what problem we have now? > >> > >> Thanks. > >> Luke > >> > >> On Thu, Aug 29, 2024 at 9:43 AM 黃竣陽 <s7133...@gmail.com> wrote: > >> > >>> Hello everyone, > >>> > >>> I would like to start a discussion about KIP-1085 > >>> < > >>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig > >>>> > >>> In this KIP, we plan to deprecate the public doc variables which only > >> used > >>> in `StreamConfig` > >>> and make them private in a future release. > >>> > >>> Any feedback and suggestions for the KIP are welcome in this email > >> thread. > >>> > >>> Thank you! > >>> Best regards, > >>> Jiunn Yang > >> > >
