Hi TengYao, Thanks for the KIP. I wonder if there’s a different way to close what is quite a small window.
AS1: It is true that the initial heartbeat is not idempotent, but this remains true with this KIP. It’s just differently not idempotent. If the client makes its own member ID, sends a request and dies, the GC will still have added the member to the group and it will hang around until the session expires. I wonder if the GC could still generate the member ID in response to the first heartbeat, and put the member in a special PENDING state with no assignments until the client sends the next heartbeat, thus confirming it has received the member ID. This would not be a protocol change at all, just a change to the GC to keep a new member in the lobby until it’s comfirmed it knows its member ID. Thanks, Andrew > On 13 Aug 2024, at 15:59, TengYao Chi <kiting...@gmail.com> wrote: > > Hi Chia-Ping, > > Thanks for review and suggestions. > I have updated the content of KIP accordingly. > Please take a look. > > Best regards, > TengYao > > Chia-Ping Tsai <chia7...@apache.org> 於 2024年8月13日 週二 下午9:45寫道： > >> hi TengYao >> >> thanks for this KIP. >> >> 1) could you please describe the before/after behavior in the "Proposed >> Changes" section? IIRC, current RPC allows HB having member id generated by >> client, right? If HB has no member ID, server will generate one and then >> return. The new behavior will enforce HB "must" have member ID. >> >> 2) could you please write the version number explicitly in the KIP >> >> 3) how new client code handle the old HB? Does it always generate member >> ID on client-side even though that is not restricted? >> >> Best, >> Chia-Ping >> >> On 2024/08/13 06:20:42 TengYao Chi wrote: >>> Hello everyone, >>> >>> I would like to start a discussion thread on KIP-1082, which proposes >>> enabling id generation for clients over the ConsumerGroupHeartbeat RPC. >>> >>> Here is the KIP Link: KIP-1082 >>> < >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1082%3A+Enable+ID+Generation+for+Clients+over+the+ConsumerGroupHeartbeat+RPC >>> >>> Please take a look and let me know what you think, and I would appreciate >>> any suggestions and feedback. >>> >>> Best regards, >>> TengYao >>> >>
