Thanks Mickael! +1 for increasing the test coverage for admin clients. But I don't think this should be the blocker for v3.8.0, given the delay of v3.8.0 and we already have many releases with this state. What do you think?
Thanks. Luke On Mon, Jul 15, 2024 at 4:57 PM Mickael Maison <mickael.mai...@gmail.com> wrote: > Hi, > > I'm concerned we did not have tests to catch that issue earlier. Such > an essential API like describeTopics() should be properly tested. > Taking a quick look, it seems a bunch of other Admin APIs also don't > have integration tests. I created > https://issues.apache.org/jira/browse/KAFKA-17137 to address that. > > Thanks, > Mickael > > On Mon, Jul 15, 2024 at 9:53 AM Josep Prat <josep.p...@aiven.io.invalid> > wrote: > > > > Hi all, > > > > I'm cancelling the VOTE thread for 3.8.0-RC0. I submitted a PR with the > > backport https://github.com/apache/kafka/pull/16593 and I'll generate a > new > > RC as soon as it's merged. > > > > Best, > > > > On Sat, Jul 13, 2024 at 7:09 PM Josep Prat <josep.p...@aiven.io> wrote: > > > > > Thanks for reviewing the RC Jakub, > > > > > > If you can open a PR with this fix pointing to the 3.8 branch I could > cut > > > another RC. > > > > > > Best! > > > > > > ------------------ > > > Josep Prat > > > Open Source Engineering Director, Aiven > > > josep.p...@aiven.io | +491715557497 | aiven.io > > > Aiven Deutschland GmbH > > > Alexanderufer 3-7, 10117 Berlin > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > On Sat, Jul 13, 2024, 16:13 Jakub Scholz <ja...@scholz.cz> wrote: > > > > > >> Hi Josep, > > >> > > >> Thanks for the RC. > > >> > > >> I gave it a quick try and ran into issues with an application using > the > > >> Kafka Admin API that looks like this issue: > > >> https://issues.apache.org/jira/browse/KAFKA-16905 ... given that this > > >> breaks what was working fine with Kafka 3.7, can the fix be > backported to > > >> 3.8.0 as well? If needed, I tried to create a simple reproducer for > the > > >> issue: > https://github.com/scholzj/kafka-admin-api-async-issue-reproducer. > > >> > > >> Thanks & Regards > > >> Jakub > > >> > > >> On Fri, Jul 12, 2024 at 11:46 AM Josep Prat > <josep.p...@aiven.io.invalid> > > >> wrote: > > >> > > >> > Hello Kafka users, developers and client-developers, > > >> > > > >> > This is the first candidate for release of Apache Kafka 3.8.0. > > >> > Some of the major features included in this release are: > > >> > * KIP-1028: Docker Official Image for Apache Kafka > > >> > * KIP-974: Docker Image for GraalVM based Native Kafka Broker > > >> > * KIP-1036: Extend RecordDeserializationException exception > > >> > * KIP-1019: Expose method to determine Metric Measurability > > >> > * KIP-1004: Enforce tasks.max property in Kafka Connect > > >> > * KIP-989: Improved StateStore Iterator metrics for detecting leaks > > >> > * KIP-993: Allow restricting files accessed by File and Directory > > >> > ConfigProviders > > >> > * KIP-924: customizable task assignment for Streams > > >> > * KIP-813: Shareable State Stores > > >> > * KIP-719: Deprecate Log4J Appender > > >> > * KIP-390: Support Compression Level > > >> > * KIP-1018: Introduce max remote fetch timeout config for > > >> > DelayedRemoteFetch requests > > >> > * KIP-1037: Allow WriteTxnMarkers API with Alter Cluster Permission > > >> > * KIP-1047 Introduce new org.apache.kafka.tools.api.Decoder to > replace > > >> > kafka.serializer.Decoder > > >> > * KIP-899: Allow producer and consumer clients to rebootstrap > > >> > > > >> > Release notes for the 3.8.0 release: > > >> > https://home.apache.org/~jlprat/kafka-3.8.0-rc0/RELEASE_NOTES.html > > >> > > > >> > *** Please download, test and vote by Monday, July 15, 12pm PT > > >> > > > >> > Kafka's KEYS file containing PGP keys we use to sign the release: > > >> > https://kafka.apache.org/KEYS > > >> > > > >> > * Release artifacts to be voted upon (source and binary): > > >> > https://home.apache.org/~jlprat/kafka-3.8.0-rc0/ > > >> > > > >> > * Docker release artifacts to be voted upon: > > >> > apache/kafka:3.8.0-rc0 > > >> > apache/kafka-native:3.8.0-rc0 > > >> > > > >> > * Maven artifacts to be voted upon: > > >> > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ > > >> > > > >> > * Javadoc: > > >> > https://home.apache.org/~jlprat/kafka-3.8.0-rc0/javadoc/ > > >> > > > >> > * Tag to be voted upon (off 3.8 branch) is the 3.8.0 tag: > > >> > https://github.com/apache/kafka/releases/tag/3.8.0-rc0 > > >> > > > >> > > > >> > Once https://github.com/apache/kafka-site/pull/608 is merged. You > will > > >> be > > >> > able to find the proper documentation under kafka.apache.org. > > >> > * Documentation: > > >> > https://kafka.apache.org/38/documentation.html > > >> > > > >> > * Protocol: > > >> > https://kafka.apache.org/38/protocol.html > > >> > > > >> > > > >> > * Successful Jenkins builds for the 3.8 branch: > > >> > Unit/integration tests: > > >> > > > >> > > > >> > https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%252Fkafka/detail/3.8/67/ > > >> > (Some known flaky tests and builds from 64 to 68 show tests passing > at > > >> > least once) > > >> > System tests: > > >> > > > >> > > > >> > https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-07-10--001.f1f05b43-3574-45cb-836e-8968f02d722f--1720631619--apache--3.8--4ecbb75c1f/report.html > > >> > > > >> > Note that the system tests can't always successfully run in CI, > > >> `QuotaTest` > > >> > have been reportedly running successfully locally by several Kafka > > >> > community members. Other flaky tests were tracked under > > >> > https://issues.apache.org/jira/browse/KAFKA-17083, > > >> > https://issues.apache.org/jira/browse/KAFKA-17084 and > > >> > https://issues.apache.org/jira/browse/KAFKA-17085. All of them run > > >> > successfully on other CI environments. > > >> > > > >> > * Successful Docker Image Github Actions Pipeline for 3.8 branch: > > >> > Docker Build Test Pipeline (JVM): > > >> > https://github.com/apache/kafka/actions/runs/9905437603 > > >> > Docker Build Test Pipeline (Native): > > >> > https://github.com/apache/kafka/actions/runs/9905490565 > > >> > > > >> > Thanks, > > >> > > > >> > -- > > >> > [image: Aiven] <https://www.aiven.io> > > >> > > > >> > *Josep Prat* > > >> > Open Source Engineering Director, *Aiven* > > >> > josep.p...@aiven.io | +491715557497 > > >> > aiven.io <https://www.aiven.io> | < > > >> https://www.facebook.com/aivencloud > > >> > > > > >> > <https://www.linkedin.com/company/aiven/> < > > >> > https://twitter.com/aiven_io> > > >> > *Aiven Deutschland GmbH* > > >> > Alexanderufer 3-7, 10117 Berlin > > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > >> > Amtsgericht Charlottenburg, HRB 209739 B > > >> > > > >> > > > > > > > -- > > [image: Aiven] <https://www.aiven.io> > > > > *Josep Prat* > > Open Source Engineering Director, *Aiven* > > josep.p...@aiven.io | +491715557497 > > aiven.io <https://www.aiven.io> | < > https://www.facebook.com/aivencloud> > > <https://www.linkedin.com/company/aiven/> < > https://twitter.com/aiven_io> > > *Aiven Deutschland GmbH* > > Alexanderufer 3-7, 10117 Berlin > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > Amtsgericht Charlottenburg, HRB 209739 B >
