Thanks for the quick action Justine, I just reviewed and approved. On Fri, Jun 14, 2024 at 11:08 AM Justine Olshan <jols...@confluent.io.invalid> wrote:
> The PR to fix is: https://github.com/apache/kafka/pull/16342/files > > On Fri, Jun 14, 2024 at 8:02 AM Justine Olshan <jols...@confluent.io> > wrote: > > > Looks like the previous cherrypick of Edoardo's feature broke the build. > I > > have a fix coming shortly. > > > > I may also want to look at the system tests again. > > > > Justine > > > > On Fri, Jun 14, 2024 at 6:06 AM Luke Chen <show...@gmail.com> wrote: > > > >> Hi all, > >> > >> After running system tests, here are failing tests: > >> > >> 1. kafkatest.tests.core.upgrade_test failed at lz4 and snappy tests: > >> KAFKA-16962 <https://issues.apache.org/jira/browse/KAFKA-16962> > >> 2. StreamsUpgradeTest failed at "fromVersion"=2.2 ~ 2.5, but passed for > >> the rest of the versions: KAFKA-16960 > >> <https://issues.apache.org/jira/browse/KAFKA-16960> > >> 3. TestKRaftUpgrade failed at "fromVersion"=3.3 ~ 3.5 under combined > >> KRaft: > >> KAFKA-16961 <https://issues.apache.org/jira/browse/KAFKA-16961> > >> > >> Need help to take a look, or maybe re-run in another environment. > >> > >> Thanks. > >> Luke > >> > >> On Fri, Jun 14, 2024 at 5:03 PM Edoardo Comar <edoardli...@gmail.com> > >> wrote: > >> > >> > well if you still need to build RC2, I'd cherry pick this that I > >> > missed from the other PR > >> > https://github.com/apache/kafka/pull/16326 > >> > > >> > On Thu, 13 Jun 2024 at 13:20, Igor Soarez <i...@soarez.me> wrote: > >> > > > >> > > Hi Edoardo, > >> > > > >> > > It is late, but not too late. I have cherry-picked your change > >> > > to the 3.7 branch and I'll build a second release candidate. > >> > > > >> > > If you could have a look at the first RC, please let me know if > >> > > you spot any issues with it that can be avoided in the next RC. > >> > > > >> > > Thanks, > >> > > > >> > > -- > >> > > Igor > >> > > >> > > >
