Thanks for the KIP Murali,
Overall LGTM. A few comments.
100: Config names are part of the public interface, and the KIP should
not say "none" in this section, but call out which configs are
deprecated and which ones are newly added.
101: Nit. In "Propose Changes" there is the template placeholder text
Describe the new thing you want to do in appropriate detail. This may be fairly
extensive and have large subsections of its own. Or it may be a few sentences.
Use judgement based on the scope of the change.
Similarly in "Test Plan" section
Please remove both :)
102: The "Deprecation" section should explain the behavior if both, old
and new configs, are set.
Thanks a lot!
-Matthias
On 6/9/24 9:30 PM, Muralidhar Basani wrote:
Hello all,
With this KIP
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-1056%3A+Remove+%60default.%60+prefix+for+exception+handler+StreamsConfig>,
I would like to mention that a couple of exception handler configs in
StreamsConfig are defined as default configs, despite having no alternative
values. Hence would propose to deprecate them and introduce new configs
without the 'default.' prefix.
This KIP is briefly discussed here in the jira KAFKA-16853
<https://issues.apache.org/jira/browse/KAFKA-16863> too.
I would appreciate any feedback or suggestions you might have.
Thanks,
Murali
