[ https://issues.apache.org/jira/browse/KAFKA-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091720#comment-14091720 ]
Manikumar Reddy commented on KAFKA-1581: ---------------------------------------- I submitted a patch for KAFKA-1374, which handles compressed messages in log compaction. We can skip messages without keys during log cleaning. I can include this in KAFKA-1374 patch. > Log cleaner should have an option to ignore messages without keys > ----------------------------------------------------------------- > > Key: KAFKA-1581 > URL: https://issues.apache.org/jira/browse/KAFKA-1581 > Project: Kafka > Issue Type: Bug > Reporter: Joel Koshy > > Right now, there is a strict requirement that compacted topics contain only > messages with keys. This makes sense, but the issue with a hard requirement > is that if it fails the cleaner quits. We should probably allow ignoring > these messages (with a warning). Alternatively, we can catch this scenario > (instead of the hard requirement) and just skip compaction for that partition. > This came up because I saw an invalid message (compressed and without a key) > in the offsets topic which broke both log compaction and the offset load > process. I filed KAFKA-1580 to prevent that from happening in the first place > but KAFKA-1580 is only for internal topics. In the general case (compacted > non-internal topics) we would not want the cleaners to exit permanently due > to an invalid (key-less) message in one of the partitions since that would > prevent compaction for other partitions as well. -- This message was sent by Atlassian JIRA (v6.2#6252)