stanislavkozlovski commented on code in PR #587:
URL: https://github.com/apache/kafka-site/pull/587#discussion_r1500054892
##########
37/streams/developer-guide/config-streams.html:
##########
@@ -730,7 +713,6 @@ <h4><a class="toc-backref"
href="#id35">rack.aware.assignment.strategy</a><a cla
<ul class="simple">
<li><code class="docutils literal"><span
class="pre">none</span></code>. This is the default value which means rack
aware task assignment will be disabled.</li>
<li><code class="docutils literal"><span
class="pre">min_traffic</span></code>. This settings means that the rack aware
task assigner will compute an assignment which tries to minimize cross rack
traffic.</li>
- <li><code class="docutils literal"><span
class="pre">balance_subtopology</span></code>. This settings means that the
rack aware task assigner will compute an assignment which will try to balance
tasks from same subtopology to different clients and minimize cross rack
traffic on top of that.</li>
Review Comment:
need to double check this and the above
##########
37/security.html:
##########
@@ -54,7 +54,7 @@ <h3 class="anchor-heading"><a id="listener_configuration"
class="anchor-link"></
<p>The <code>LISTENER_NAME</code> is usually a descriptive name which
defines the purpose of
the listener. For example, many configurations use a separate listener
for client traffic,
- so they might refer to the corresponding listener as <code>CLIENT</code>
in the configuration:</p>
+ so they might refer to the corresponding listener as <code>CLIENT</code>
in the configuration:</p
Review Comment:
broken <p> - need to fix in apache/kafka
##########
37/generated/kafka_config.html:
##########
@@ -1357,7 +1357,7 @@ <h4><a id="inter.broker.protocol.version"></a><a
id="brokerconfigs_inter.broker.
<p>Specify which version of the inter-broker protocol will be used.<br> This
is typically bumped after all brokers were upgraded to a new version.<br>
Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0,
0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list.</p>
<table><tbody>
<tr><th>Type:</th><td>string</td></tr>
-<tr><th>Default:</th><td>3.8-IV0</td></tr>
+<tr><th>Default:</th><td>3.7-IV4</td></tr>
Review Comment:
This is the correct change. Quite the bug it was previously the other one.
In the 3.7 branch in apache/kafka, we have the code:
```
/**
* The latest production-ready MetadataVersion. This is the latest
version that is stable
* and cannot be changed. MetadataVersions later than this can be tested
via junit, but
* not deployed in production.
*
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
public static final MetadataVersion LATEST_PRODUCTION = IBP_3_7_IV4;
```
##########
37/security.html:
##########
@@ -54,7 +54,7 @@ <h3 class="anchor-heading"><a id="listener_configuration"
class="anchor-link"></
<p>The <code>LISTENER_NAME</code> is usually a descriptive name which
defines the purpose of
the listener. For example, many configurations use a separate listener
for client traffic,
- so they might refer to the corresponding listener as <code>CLIENT</code>
in the configuration:</p>
+ so they might refer to the corresponding listener as <code>CLIENT</code>
in the configuration:</p
Review Comment:
broken <p> - need to fix in apache/kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
