> On Aug. 6, 2014, 4:39 a.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/TransactionManager.scala, line 300 > > <https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300> > > > > If the batch size changes to a smaller number does the tx Id range > > overlap then?
Why? The tx Id range should not overlap regardless of the actual value of batch size. > On Aug. 6, 2014, 4:39 a.m., Timothy Chen wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 109 > > <https://reviews.apache.org/r/23568/diff/6/?file=653408#file653408line109> > > > > Why not use the InternalTopics array here? Thanks! This is a good point, and I will use InternalTopics in the updated patch. > On Aug. 6, 2014, 4:39 a.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 255 > > <https://reviews.apache.org/r/23568/diff/6/?file=653413#file653413line255> > > > > that is quite a mouthful, should it be called just > > producerTxRequestToCoordinator? I agree, it is quite mouthful. When naming the functions producerRequestFromTxRequestToBroker and producerRequestFromTxRequestToBroker, I just want to be consistent with the name producerRequestFromOffsetCommit. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review49692 ----------------------------------------------------------- On Aug. 6, 2014, 4:25 a.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23568/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 4:25 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1523 > https://issues.apache.org/jira/browse/KAFKA-1523 > > > Repository: kafka > > > Description > ------- > > KAFKA-1523 Transaction manager and its failover handling. > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > 003a09c6160618bc94858ebc0d806b2aa4158e0a > core/src/main/scala/kafka/cluster/Partition.scala > 134aef9c88068443d4d465189f376dd78605b4f8 > core/src/main/scala/kafka/common/Topic.scala > ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 > core/src/main/scala/kafka/message/Message.scala > d2a7293c7be4022af30884330924791340acc5c1 > core/src/main/scala/kafka/server/KafkaApis.scala > fd5f12ee31e78cdcda8e24a0ab3e1740b3928884 > core/src/main/scala/kafka/server/KafkaConfig.scala > 1a45f8716ccc0398cf9395d91d66199d16882aae > core/src/main/scala/kafka/server/KafkaServer.scala > 28711182aaa70eaa623de858bc063cb2613b2a4d > core/src/main/scala/kafka/server/ReplicaManager.scala > 897783cb756de548a8b634876f729b63ffe9925e > core/src/main/scala/kafka/server/RequestPurgatory.scala > 3d0ff1e2dbd6a5c3587cffa283db70415af83a7b > core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION > core/src/main/scala/kafka/utils/ZkUtils.scala > dcdc1ce2b02c996294e19cf480736106aaf29511 > > Diff: https://reviews.apache.org/r/23568/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
