----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review49611 -----------------------------------------------------------
Thanks for the patch. Some comments below. core/src/main/scala/kafka/log/LogCleaner.scala <https://reviews.apache.org/r/24214/#comment86836> We probably should just record the compressed size in stats.recopyMessage() since that's the size actually got copied over. core/src/main/scala/kafka/log/LogCleaner.scala <https://reviews.apache.org/r/24214/#comment86842> Could we use Compressor.putRecord? Then,we don't have to worry about the details of the message format. core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala <https://reviews.apache.org/r/24214/#comment86841> Would it be better to make this a parameterized test so that we can test all compression codec? - Jun Rao On Aug. 3, 2014, 5:40 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24214/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2014, 5:40 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1374 > https://issues.apache.org/jira/browse/KAFKA-1374 > > > Repository: kafka > > > Description > ------- > > LogCleaner code decompresses the compressed messages and writes back the > retained/compacted messages in compressed form > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > afbeffc72e7d7706b44961aecf8519c5c5a3b4b1 > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 5bfa764638e92f217d0ff7108ec8f53193c22978 > > Diff: https://reviews.apache.org/r/24214/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
