Hi Jose, Thanks for the KIP! A few initial questions below:
1. In the user experience section, the user is expected to provide supply the UUID for each voter. I'm assuming this is the directory.id coming from KIP-858. I thought it was generated by the format comand automatically? It seems like we will need a way to specify it explicitly. 2. Do we need the AddVoters and RemoveVoters control records? Perhaps the VotersRecord is sufficient since changes to the voter set will be rare. 3. Why does UpdateVoter need to commit after every leader change? 4. Should ReplicaUuid in FetchRequest be a tagged field? It seems like a lot of overhead for all consumer fetches. 5. I was looking for the correctness conditions when changing the voter set. I recalled something about always taking the voter set from the log even if it is not yet known to be committed. Do you have those details documented? -Jason On Mon, Jan 8, 2024 at 10:13 AM José Armando García Sancio <jsan...@confluent.io.invalid> wrote: > Hi all, > > KIP-853: KRaft Controller Membership Changes is ready for another > round of discussion. > > There was a previous discussion thread at > https://lists.apache.org/thread/zb5l1fsqw9vj25zkmtnrk6xm7q3dkm1v > > I have changed the KIP quite a bit since that discussion. The core > idea is still the same. I changed some of the details to be consistent > with some of the protocol changes to Kafka since the original KIP. I > also added a section that better describes the feature's UX. > > KIP: https://cwiki.apache.org/confluence/x/nyH1D > > Thanks. Your feedback is greatly appreciated! > -- > -José >
