Hi Ismael, I added this automatically approach to “Rejected alternatives” concerning that we need to unify the semantics between alterConfigs and incrementalAlterConfigs, so I choose to give this privilege to users.
After reviewing these code and doing some tests I found that they following the similar approach, I think the simplest way is to let the client choose the best method heuristically. Thank you for pointing out this, I will change the KIP later. Best, Ziming > On Jan 4, 2024, at 17:28, Ismael Juma <m...@ismaeljuma.com> wrote: > > Hi Ziming, > > Why is the flag required at all? Can we use incremental and fallback > automatically if it's not supported by the broker? At this point, the vast > majority of clusters should support it. > > Ismael > > On Mon, Dec 18, 2023 at 7:58 PM ziming deng <dengziming1...@gmail.com > <mailto:dengziming1...@gmail.com>> wrote: >> >> Hello, I want to start a discussion on KIP-1011, to make the broker config >> change path unified with that of user/topic/client-metrics and avoid some >> bugs. >> >> Here is the link: >> >> KIP-1011: Use incrementalAlterConfigs when updating broker configs by >> kafka-configs.sh - Apache Kafka - Apache Software Foundation >> cwiki.apache.org >> >> >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh>KIP-1011: >> Use incrementalAlterConfigs when updating broker configs by >> kafka-configs.sh - Apache Kafka - Apache Software Foundation >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh> >> cwiki.apache.org >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh> >> >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh> >> >> Best, >> Ziming.
