The voting for this KIP is now complete. +3 binding (Jun, Jason, Matthias) +2 non-binding (Doğuşcan, Apoorv)
Thanks, Andrew > On 20 Nov 2023, at 21:42, Jason Gustafson <ja...@confluent.io.INVALID> wrote: > > +1 Thanks for the KIP! > > On Mon, Nov 20, 2023 at 9:31 AM Jun Rao <j...@confluent.io.invalid> wrote: > >> Hi, Andrew, >> >> Thanks for the KIP. +1 >> >> Jun >> >> On Thu, Nov 16, 2023 at 9:12 AM Andrew Schofield < >> andrew_schofield_j...@outlook.com> wrote: >> >>> Hi Apoorv, >>> Thanks for your vote. >>> >>> Initially, I put support for zkBroker in order to be able to control the >>> error response in this case. >>> I have validated the error handling for this RPC on a ZK cluster in which >>> the RPC is not supported, >>> and the error is entirely understandable. Consequently, I have removed >>> `zkBroker` for this new RPC. >>> >>> Thanks, >>> Andrew >>> >>>> On 16 Nov 2023, at 13:51, Apoorv Mittal <apoorvmitta...@gmail.com> >>> wrote: >>>> >>>> Thanks a lot for writing the KIP Andrew. This is much required to list >>> all >>>> configured client metrics resources. >>>> >>>> I have one minor question related to the zkBroker listener in the new >>> RPC. >>>> As the client-metrics resource is not supported in Zookeeper mode hence >>>> shouldn't we disallow ListClientMetricsResourcesRequest for >>>> Zookeper in the APIVersion request itself? >>>> >>>> +1(non-binding) >>>> >>>> Regards, >>>> Apoorv Mittal >>>> +44 7721681581 >>>> >>>> >>>> On Wed, Nov 15, 2023 at 4:58 PM Andrew Schofield < >>>> andrew_schofield_j...@outlook.com> wrote: >>>> >>>>> Hi, >>>>> I’d like to start the voting for KIP-1000: List Client Metrics >>>>> Configuration Resources. >>>>> >>>>> >>>>> >>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1000%3A+List+Client+Metrics+Configuration+Resources >>>>> >>>>> Thanks, >>>>> Andrew
