----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24113/#review49158 -----------------------------------------------------------
core/src/main/scala/kafka/admin/AdminUtils.scala <https://reviews.apache.org/r/24113/#comment86001> you can remove named params here and use "config,true" - Sriharsha Chintalapani On July 30, 2014, 8:18 p.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24113/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 8:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1562 > https://issues.apache.org/jira/browse/KAFKA-1562 > > > Repository: kafka > > > Description > ------- > > KAFKA-1562 kafka-topics.sh alter add partitions resets cleanup.policy > > > Diffs > ----- > > core/src/main/scala/kafka/admin/AdminUtils.scala > b5d8714e964fee8b29b05db04d79fd6ac84f3e48 > core/src/main/scala/kafka/admin/TopicCommand.scala > 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf > core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/24113/diff/ > > > Testing > ------- > > Automated > > > Thanks, > > Jonathan Natkins > >
