Hi Tina, Thanks for the KIP. For clarity it might make sense to mention this feature will be useful when using a ConfigProvider with Kafka Connect as providers are set in the runtime and can then be used by connectors. This feature has no use when using a ConfigProvider in server.properties or in clients.
When trying to use a path not allowed, you propose returning an error. With Connect does that mean the connector will be failed? The EnvVarConfigProvider returns empty string in case a user tries to access an environment variable not allowed. I wonder if we should follow the same pattern so the behavior is "consistent" across all built-in providers. Thanks, Mickael On Tue, Nov 7, 2023 at 1:52 PM Gantigmaa Selenge <gsele...@redhat.com> wrote: > > Hi everyone, > > Please let me know if you have any comments on the KIP. > > I will leave it for a few more days. If there are still no comments, I will > start the vote on it. > > Regards, > Tina > > On Wed, Oct 25, 2023 at 8:31 AM Gantigmaa Selenge <gsele...@redhat.com> > wrote: > > > Hi everyone, > > > > I would like to start a discussion on KIP-933 that proposes restricting > > files accessed by File and Directory ConfigProviders. > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-993%3A+Allow+restricting+files+accessed+by+File+and+Directory+ConfigProviders > > > > Regards, > > Tina > >
