----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23962/#review48965 -----------------------------------------------------------
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala <https://reviews.apache.org/r/23962/#comment85808> I think we need to first update leaderId here based on the value returned from getControllerID(), and then check if the controller exists. Otherwise, if the another broker is the controller, this broker's leaderId won't be updated correctly. - Jun Rao On July 28, 2014, 2:59 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23962/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 2:59 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1451 > https://issues.apache.org/jira/browse/KAFKA-1451 > > > Repository: kafka > > > Description > ------- > > Addresing Jun's Comments > > > Diffs > ----- > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala > e5b6ff1e2544b043007cf16a6b9dd4451c839e63 > > Diff: https://reviews.apache.org/r/23962/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
