----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48877 -----------------------------------------------------------
Good stuff, I was able to get all binaries to build and pass tests with this patch. I think a fix to maintain compatibility with the BeanProperty change is important, but the other two aren't so much. build.gradle <https://reviews.apache.org/r/23895/#comment85642> I think the file can be removed so that the exclusion isn't needed. core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala <https://reviews.apache.org/r/23895/#comment85644> you need to add `def getBuffer = buffer` here and below in order to maintain backwards compatibility (those are added by the @BeanProperty annotation). You could also do something similar to `kafka.utils.Annotations_2.9+.scala` and the groovy excludes to keep the BeanProperty annotation working. gradle.properties <https://reviews.apache.org/r/23895/#comment85643> I hesitate to nit, but scala 2.11.2 was released 6 days ago. Might be worth switching if it doesn't cause any issues? - Joe Crobak On July 28, 2014, 3:07 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23895/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 3:07 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1419 > https://issues.apache.org/jira/browse/KAFKA-1419 > > > Repository: kafka > > > Description > ------- > > KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor > bug fixes > > > Diffs > ----- > > build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 > core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala > fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 73401c5ff34d08abce22267aa9c4d86632c6fb74 > gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b > gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 > gradle/wrapper/gradle-wrapper.properties > 610282a699afc89a82203ef0e4e71ecc53761039 > scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 > > Diff: https://reviews.apache.org/r/23895/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
