Hi Viktor, When you say "I don't see the config you introduced on the KIP" - do you mean that the potential config key name is not specified? Or are there any other specific details I need to add? If so, could you please link an example KIP that I can reference? Thanks alot!
On Wed, 27 Sept 2023 at 14:17, Viktor Somogyi-Vass <viktor.somo...@cloudera.com.invalid> wrote: > Hi Elkhan, > > I don't see the config you introduced on the KIP. Otherwise it looks > good to me. If no one has objections or anything to add then I think you > can start the vote after updating the KIP. > > >I added the configurable poll interval as an optional - I believe it is > useful to let users to configure it but I doubt whether it would actually > be used. > > Yes, it definitely won't be a high priority config but it's defensive. In > case of very large clusters I can imagine users might want longer periods > to avoid any unnecessary pressure from MM2. > > Viktor > > On Wed, Sep 27, 2023 at 12:50 AM Elxan Eminov <elxanemino...@gmail.com> > wrote: > > > Hi Team, > > Just pinging this > > > > Thanks, > > Elkhan > > > > On Thu, 21 Sep 2023 at 23:09, Elxan Eminov <elxanemino...@gmail.com> > > wrote: > > > > > Hi Viktor and huqedi, > > > I've made the changes to the KIP. > > > I added the configurable poll interval as an optional - I believe it is > > > useful to let users to configure it but I doubt whether it would > actually > > > be used. > > > Please let me know your thoughts on this, > > > Thanks! > > > > > > On Sat, 26 Aug 2023 at 15:49, Elxan Eminov <elxanemino...@gmail.com> > > > wrote: > > > > > >> Relatively minor change with a new metric for MM2 > > >> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-971%3A+Expose+replication-offset-lag+MirrorMaker2+metric > > >> > > > > > >
