[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074513#comment-14074513 ]
Joe Stein commented on KAFKA-1477: ---------------------------------- [~junrao] While I think it make sense to not try to add too much to the existing producer and consumer they are being used in the wild quite heavily right now. There is real need for this feature (besides Salesforce others are doing security with Kafka outside of the upstream project and starting to-do things differently enough that the solution is becoming inconsistent) and a lot of this is really about the changes to the broker... Once the patch is committed then any client (Go, Python, etc) can implement SSL with the Broker. The existing producer/consumer can also be used out of the box for folks that want to flip the feature on now. Waiting for the new producer won't work IMHO from a product perspective because then we only delivered half the solution (the other half being consuming over SSL). We can get the feature in now for something that folks are using already (this is an upgrade to Raja's original work to latest trunk). I understand this may extend the life of the existing producer/consumer a little bit until the new producer and consumer support the feature too. I think the reality though is that existing producer / consumer will be around as folks will be slow to upgrade though I do expect them to eventually move to "shiny new" once it becomes less new or they have a real need for the change (some do not). If there are no objections (-1 s) to the patch Ivan posted he should have this done finalized within the next 2-3 weeks (minor things). Once done with review and testing I expect to +1 and commit the patch. I also appreciate the extent of the change and also appreciate any effort that can be made to help vet this change to make sure Kafka keeps doing everything that everyone expects Kafka to be doing when the feature is not on. > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -------------------------------------------------------------------------------------------------------------------------- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature > Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)