> On July 24, 2014, 1:21 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, line 718 > > <https://reviews.apache.org/r/23702/diff/3/?file=639483#file639483line718> > > > > Shouldn't we be using createPersistentSequential?
if I used createPersistentSequential it keeps creating a new node in zk with a sequential number. It will leave too many nodes in zk depending on the number of brokers that the user run. Instead I used a path each time updating with a expected version -1 and using returned stat.getVersion for the sequential number. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23702/#review48598 ----------------------------------------------------------- On July 22, 2014, 6:34 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23702/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1070 > https://issues.apache.org/jira/browse/KAFKA-1070 > > > Repository: kafka > > > Description > ------- > > KAFKA-1070. Auto assign node id. > > > KAFKA-1070. Auto-assign node id. > > > Diffs > ----- > > core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaConfig.scala > 50b09edb73af1b45f88f919ac8c46ae056878c8e > core/src/main/scala/kafka/server/KafkaServer.scala > def1dc2a5818d45d9ee0881137ff989cec4eb9b1 > core/src/main/scala/kafka/utils/ZkUtils.scala > dcdc1ce2b02c996294e19cf480736106aaf29511 > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 3faa884f8eb83c7c00baab416d0acfb488dc39c1 > > Diff: https://reviews.apache.org/r/23702/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
