Hi all, It's been a few days so I went ahead with editing the KIP, the main change is on the method name https://cwiki.apache.org/confluence/display/KAFKA/KIP-759%3A+Unneeded+repartition+canceling. I will follow up with a VOTE separately.
Best, Shay On Thu, Jun 29, 2023 at 4:52 PM Matthias J. Sax <mj...@apache.org> wrote: > Shay, > > thanks for picking up this KIP. It's a pity that the discussion stalled > for such a long time. > > As expressed previously, I am happy with the name `markAsPartitioned()` > and also believe it's ok to just document the impact and leave it to the > user to do the right thing. > > If we really get a lot of users that ask about it, because they did not > do the right thing, we could still add something (eg, a reverse-mapper > function) in a follow-up KIP. But we don't know if it's necessary; thus, > making a small incremental step sounds like a good approach to me. > > Let's see if others agree or not. > > > -Matthias > > On 6/28/23 5:29 PM, Shay Lin wrote: > > Hi all, > > > > Great discussion thread. May I take this KIP up? If it’s alright my plan > is > > to update the KIP with the operator `markAsPartitioned()`. > > > > As you have discussed and pointed out, there are implications to > downstream > > joins or aggregation operations. Still, the operator is intended for > > advanced users so my two cents is it would be a valuable addition > > nonetheless. We could add this as a caution/consideration as part of the > > java doc. > > > > Let me know, thanks. > > Shay > > >
