Thanks for pointing this out. Could you file a Apache jira and attach you patch there?
Jun On Tue, Jul 22, 2014 at 8:40 AM, MarkRose <g...@git.apache.org> wrote: > GitHub user MarkRose opened a pull request: > > https://github.com/apache/kafka/pull/28 > > Clarify log expiry configuration options (for trunk) > > I spent a bit of time tracking down why files were being deleted > before they reached log.retention.hours of age. It turns out that the time > and size log retention schemes function independently, and not as the > original comment "The minimum age of a log file to be eligible for > deletion" might indicate to a new user. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/MarkRose/kafka > fix_misleading_configuration_file_for_trunk > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/kafka/pull/28.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #28 > > ---- > commit 6c8af74e74437e3de71d12c17bfa90920c1dc8fb > Author: Mark Rose <markr...@markrose.ca> > Date: 2014-07-22T15:32:19Z > > Clarify log expiry configuration options. > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
