Hi Mickael, Thanks for running the release. +1 (non-binding)
- Ran testAll/releaseTarGzAll successfully with no failures. - Ran through quickstart of core/streams on builds generated from 3.5.0-rc1 tag. - Ran a few internal apps targeting to topics on a 3 node cluster. On Mon, 12 Jun 2023 at 12:31, Josep Prat <josep.p...@aiven.io.invalid> wrote: > > Hi MIckael, > Just for the record, I +1'd this release. However, my vote falls onto the > non-binding ones as well. > > Best, > > On Sun, Jun 11, 2023 at 11:38 AM Mickael Maison <mickael.mai...@gmail.com> > wrote: > > > Hi, > > > > We've passed the deadline but we are still missing votes. > > So far we have have 2 binding votes (Luke and John) and 2 non-binding > > votes (Federico and Jakub). > > > > Please take time to test this release candidate and vote. > > > > Thanks, > > Mickael > > > > On Wed, Jun 7, 2023 at 6:26 PM John Roesler <vvcep...@apache.org> wrote: > > > > > > Thanks for running this release, Mickael! > > > > > > I've verified: > > > * the signature > > > * that I can compile the project > > > * that I can run the tests. I saw one flaky test failure, but I don't > > think it should block us. Reported as > > https://issues.apache.org/jira/browse/KAFKA-13531?focusedCommentId=17730190 > > > * the Kafka, Consumer, and Streams quickstarts with ZK and KRaft > > > > > > I'm +1 (binding) > > > > > > Thanks, > > > -John > > > > > > On Wed, Jun 7, 2023, at 06:16, Josep Prat wrote: > > > > Hi MIckael, > > > > > > > > Apparently you did it in this PR already :) : > > > > https://github.com/apache/kafka/pull/13749 (this PR among other things > > > > removes classgraph. > > > > > > > > Without being a lawyer, I think I agree with you as stating we depend > > on > > > > something we don't would be less problematic than the other way around. > > > > > > > > Best, > > > > > > > > On Wed, Jun 7, 2023 at 12:14 PM Mickael Maison < > > mickael.mai...@gmail.com> > > > > wrote: > > > > > > > >> Hi Josep, > > > >> > > > >> Thanks for spotting this. If not already done, can you open a > > > >> ticket/PR to fix this on trunk? It looks like the last couple of > > > >> releases already had that issue. Since we're including a license for a > > > >> dependency we don't ship, I think we can consider this non blocking. > > > >> The other way around (shipping a dependency without its license) would > > > >> be blocking. > > > >> > > > >> Thanks, > > > >> Mickael > > > >> > > > >> On Tue, Jun 6, 2023 at 10:10 PM Jakub Scholz <ja...@scholz.cz> wrote: > > > >> > > > > >> > +1 (non-binding) ... I used the staged binaries with Scala 2.13 and > > > >> staged > > > >> > artifacts to run my tests. All seems to work fine. > > > >> > > > > >> > Thanks for running the release Mickael! > > > >> > > > > >> > Jakub > > > >> > > > > >> > On Mon, Jun 5, 2023 at 3:39 PM Mickael Maison <mimai...@apache.org> > > > >> wrote: > > > >> > > > > >> > > Hello Kafka users, developers and client-developers, > > > >> > > > > > >> > > This is the second candidate for release of Apache Kafka 3.5.0. > > Some > > > >> > > of the major features include: > > > >> > > - KIP-710: Full support for distributed mode in dedicated > > MirrorMaker > > > >> > > 2.0 clusters > > > >> > > - KIP-881: Rack-aware Partition Assignment for Kafka Consumers > > > >> > > - KIP-887: Add ConfigProvider to make use of environment variables > > > >> > > - KIP-889: Versioned State Stores > > > >> > > - KIP-894: Use incrementalAlterConfig for syncing topic > > configurations > > > >> > > - KIP-900: KRaft kafka-storage.sh API additions to support SCRAM > > for > > > >> > > Kafka Brokers > > > >> > > > > > >> > > Release notes for the 3.5.0 release: > > > >> > > > > https://home.apache.org/~mimaison/kafka-3.5.0-rc1/RELEASE_NOTES.html > > > >> > > > > > >> > > *** Please download, test and vote by Friday June 9, 5pm PT > > > >> > > > > > >> > > Kafka's KEYS file containing PGP keys we use to sign the release: > > > >> > > https://kafka.apache.org/KEYS > > > >> > > > > > >> > > * Release artifacts to be voted upon (source and binary): > > > >> > > https://home.apache.org/~mimaison/kafka-3.5.0-rc1/ > > > >> > > > > > >> > > * Maven artifacts to be voted upon: > > > >> > > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ > > > >> > > > > > >> > > * Javadoc: > > > >> > > https://home.apache.org/~mimaison/kafka-3.5.0-rc1/javadoc/ > > > >> > > > > > >> > > * Tag to be voted upon (off 3.5 branch) is the 3.5.0 tag: > > > >> > > https://github.com/apache/kafka/releases/tag/3.5.0-rc1 > > > >> > > > > > >> > > * Documentation: > > > >> > > https://kafka.apache.org/35/documentation.html > > > >> > > > > > >> > > * Protocol: > > > >> > > https://kafka.apache.org/35/protocol.html > > > >> > > > > > >> > > * Successful Jenkins builds for the 3.5 branch: > > > >> > > Unit/integration tests: I'm struggling to get all tests to pass > > in the > > > >> > > same build. I'll run a few more builds to ensure each test pass at > > > >> > > least once in the CI. All tests passed locally. > > > >> > > System tests: The build is still running, I'll send an update > > once I > > > >> > > have the results. > > > >> > > > > > >> > > Thanks, > > > >> > > Mickael > > > >> > > > > > >> > > > > > > > > > > > > -- > > > > [image: Aiven] <https://www.aiven.io> > > > > > > > > *Josep Prat* > > > > Open Source Engineering Director, *Aiven* > > > > josep.p...@aiven.io | +491715557497 > > > > aiven.io <https://www.aiven.io> | < > > https://www.facebook.com/aivencloud> > > > > <https://www.linkedin.com/company/aiven/> < > > https://twitter.com/aiven_io> > > > > *Aiven Deutschland GmbH* > > > > Alexanderufer 3-7, 10117 Berlin > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > -- > [image: Aiven] <https://www.aiven.io> > > *Josep Prat* > Open Source Engineering Director, *Aiven* > josep.p...@aiven.io | +491715557497 > aiven.io <https://www.aiven.io> | <https://www.facebook.com/aivencloud> > <https://www.linkedin.com/company/aiven/> <https://twitter.com/aiven_io> > *Aiven Deutschland GmbH* > Alexanderufer 3-7, 10117 Berlin > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > Amtsgericht Charlottenburg, HRB 209739 B
