[ 
https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069473#comment-14069473
 ] 

Guozhang Wang commented on KAFKA-1420:
--------------------------------------

Hi Jonathan,

TestUtils.createBrokerConfigs() is usually used when the test class is 
inheriting from KafkaServerTestHarness, which already handles server creation 
and shutdown at setUp() and tearDown() time; TestUtils.createServer() should 
then be used otherwise, i.e. when a broker is just needed to be created on the 
fly.

TestUtils.createBrokersInZk() is different, though, in that it does not 
actually create a running server, but just create the registration znode in ZK, 
the Broker object is just a placeholder for the broker metadata, like broker 
id, address, etc. They should only be used when we just need to test some 
ZK-based utilities but do not necessarily need to really create a running 
server.

> Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with 
> TestUtils.createTopic in all unit tests
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1420
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1420
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>              Labels: newbie
>             Fix For: 0.8.2
>
>
> This is a follow-up JIRA from KAFKA-1389



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to