Thanks for providing answers to my suggestions folks. Based on your answers, it seems like the KIP wants to do, relative duration = (now - timestamp), where "now" is in UTC (and not in your machine's locale/timezone). Perhaps, it's worth clarifying in the KIP? Other than that, no more comments from my side. The proposal looks good to me.
-- Divij Vaidya On Thu, May 11, 2023 at 9:52 AM Federico Valeri <fedeval...@gmail.com> wrote: > Hi Divij, thanks for having a look. > > On Wed, May 10, 2023 at 8:03 PM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > > > > Thank you for the KIP. > > > > The current proposal has the limitation that it uses a duration syntax > for > > representation of a timestamp. Also, the syntax relies on the locale and > > timezone of the caller machine. This makes it difficult to share the > output > > with others. As an example, let's say you want to share the state of the > > quorum with me which was captured but "3s ago" gives me no information on > > when it was executed. > > > > AFAIK, Unix timestamps are based on UTC, so there is no locale involved > here. > > > Alternatively, may I suggest introducing a parameter called > > "--datetime-format=" which takes as value the ISO-8601 [1] format and > > prints the timestamp based on the provided format. It would solve the > > problem of readability (epochs are hard to read!) as well as the problem > of > > portability of output across machines. > > > > What do you think? > > > > This could be a further improvement, but my point is that it is more > important to show the delay since the last time the operation was > performed, rather than the exact date. In that sense I think it is > more readable. Happy to hear other opinions on this. > > > [1] https://en.wikipedia.org/wiki/ISO_8601 > > > > -- > > Divij Vaidya > > > > > > > > On Wed, May 10, 2023 at 6:10 PM Federico Valeri <fedeval...@gmail.com> > > wrote: > > > > > Hi all, I'd like to start a new discussion thread on KIP-927: Improve > > > the kafka-metadata-quorum output. > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-927%3A+Improve+the+kafka-metadata-quorum+output > > > > > > This KIP is small and proposes to add a new optional flag to have a > > > human-readable timestamp output. > > > > > > Thank you! > > > > > > Br > > > Fede > > > >
