+1 (non-binding) Thanks ShunKang!
On Wed, May 10, 2023, at 7:26 PM, Luke Chen wrote: > +1(binding) from me. > Thanks for the improvement! > > Luke > > On Sun, May 7, 2023 at 6:34 PM Divij Vaidya <divijvaidy...@gmail.com> wrote: > > > Vote +1 (non binding) > > > > I think that this is a nice improvement as it prevents an unnecessary data > > copy for users who are using ByteBuffer serialization on the producer. > > > > -- > > Divij Vaidya > > > > > > > > On Sun, May 7, 2023 at 9:24 AM ShunKang Lin <linshunkang....@gmail.com> > > wrote: > > > > > Hi everyone, > > > > > > I'd like to open the vote for KIP-872, which proposes to add > > > Serializer#serializeToByteBuffer() to reduce memory copying. > > > > > > The proposal is here: > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828 > > > > > > The pull request is here: > > > https://github.com/apache/kafka/pull/12685 > > > > > > Thanks to all who reviewed the proposal, and thanks in advance for taking > > > the time to vote! > > > > > > Best, > > > ShunKang > > > > > >
