----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23646/#review48280 -----------------------------------------------------------
Looks good to me - although there will be some edits after Dong incorporates comments from the other RB. Also, KAFKA-1462 overlaps with the offset commit/response - may need to rebase. - Joel Koshy On July 17, 2014, 5:27 p.m., Raul Castro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23646/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 5:27 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1541 > https://issues.apache.org/jira/browse/KAFKA-1541 > > > Repository: kafka > > > Description > ------- > > KAFKA-1541; add transactional request definitions to client package > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java > 6fe7573973832615976defa37fe0dfbb8f911939 > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > 3374bd98be8e565608c4e764ed10afdae383fb6f > clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java > 044b03061802ee5e8ea4f1995fb0988e1a70e9a7 > > clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/TransactionCoordinatorMetadataRequest.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/TransactionCoordinatorMetadataResponse.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/TransactionRequest.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/TransactionResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23646/diff/ > > > Testing > ------- > > > Thanks, > > Raul Castro Fernandez > >
