Do we even need a manual attribution for a reviewer in the commit message? GitHub automatically marks the folks as "reviewers" who have used the "review-changes" button on the top left corner and left feedback. GitHub also has searchability for such reviews done by a particular person using the following link:
https://github.com/search?q=is%3Apr+reviewed-by%3A <add-reviewer>+repo%3Aapache%2Fkafka+repo%3Aapache%2Fkafka-site&type=issues (replace <add-reviewer> with the GitHub username) -- Divij Vaidya On Tue, Apr 18, 2023 at 4:09 PM Viktor Somogyi-Vass <viktor.somo...@cloudera.com.invalid> wrote: > I'm not that familiar with Actions either, it just seemed like a tool for > this purpose. :) > I Did some digging and what I have in mind is that on pull request review > it can trigger a workflow: > > https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review > > We could in theory use Github CLI to edit the description of the PR when > someone gives a review (or we could perhaps enable this to simply comment > too): > > https://docs.github.com/en/actions/using-workflows/using-github-cli-in-workflows > > So the action definition would look something like this below. Note that > the "run" part is very basic, it's just here for the idea. We'll probably > need a shell script instead of that line to format it better. But the point > is that it edits the PR and adds the reviewer: > > name: Add revieweron: > issues: > types: > - pull_request_reviewjobs: > comment: > runs-on: ubuntu-latest > steps: - run: gh pr edit $PR_ID --title "$PR_TITLE" --body > "$PR_BODY\n\nReviewers: $SENDER" > env: > GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} > PR_ID: ${{ github.event.pull_request.id }} > PR_TITLE: ${{ github.event.pull_request.title }} > PR_BODY: ${{ github.event.pull_request.body }} > SENDER: ${{ github.event.sender }} > > I'll take a look if I can try this out one my fork and get back if it leads > to anything. > > Viktor > > On Tue, Apr 18, 2023 at 10:12 AM Josep Prat <josep.p...@aiven.io.invalid> > wrote: > > > Hi all, > > Unless I miss something, wouldn't this GitHub action either amend the > > commit (breaking signature if any) or directly do the commit itself > > (meaning the action would be the one squashing and merging and not the > > maintainer anymore)? > > > > Let me know if I'm missing something or if there are some nice hidden > > tricks in GitHub that I didn't know :) > > > > Best, > > On Tue, Apr 18, 2023 at 9:48 AM Viktor Somogyi-Vass > > <viktor.somo...@cloudera.com.invalid> wrote: > > > > > Hi all, > > > > > > Unfortunately I forgot to add myself as a reviewer *again *on a PR when > > > merging. Shame on me. > > > However I was thinking about looking into Github actions whether we can > > > automate this process or at least prevent PRs from merging that don't > > have > > > "reviewers" in the description. > > > > > > Has anyone ever looked at it, is it worth chasing this or does anyone > > know > > > anything that'd prevent us from using it? > > > > > > Viktor > > > > > > > > > -- > > [image: Aiven] <https://www.aiven.io> > > > > *Josep Prat* > > Open Source Engineering Director, *Aiven* > > josep.p...@aiven.io | +491715557497 > > aiven.io <https://www.aiven.io> | < > https://www.facebook.com/aivencloud > > > > > <https://www.linkedin.com/company/aiven/> < > > https://twitter.com/aiven_io> > > *Aiven Deutschland GmbH* > > Alexanderufer 3-7, 10117 Berlin > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > Amtsgericht Charlottenburg, HRB 209739 B > > >
