Hi Neil,
I think you are right that the type is wrong. Thank you for spotting the
mistake!
Since there is a MBean name column, I do not think we need to introduce
a new section. We just need to change
"type=stream-processor-node-metrics" to "type=stream-topic-metrics" for
metrics
bytes-consumed-total
bytes-produced-total
records-consumed-total
records-produced-total
Those metrics have already the "topic" property added to the MBean name.
All other metrics in the table do not have that property.
What do you think?
Best,
Bruno
On 13.03.23 22:59, Neil Buesing wrote:
I have been looking at the new metrics in KAFKA-13945 (KIP-846). The
documentation states that this metrics are procesor-node metrics
https://kafka.apache.org/documentation/#kafka_streams_node_monitoring
*kafka.streams:type=stream-processor-node-metrics,thread-id=([-.\w]+),task-id=([-.\w]+),processor-node-id=([-.\w]+),topic=([-.\w]+)*
My observations is that the documentation should have a
"stream-topic-metrics" section
*kafka.streams:type=stream-topic-metrics,thread-id=([-.\w]+),task-id=([-.\w]+),processor-node-id=([-.\w]+),topic=([-.\w]+)*
It looks like they are in TopicMetrics.java which was created for this
effort.
I believe this is just a minor document change adding a new section "Task
Metrics" and placing these 4 metrics in this section with the given type.
Thanks,
-Neil
