Thanks for the KIP.

Overall LGMT.

One comment: Both `BooleanSerializer` and `BooleanDeserializer` are also new classes that are added and should be listed explicitly similar to `BooleanSerde` in the "Public Interfaces" section of the KIP.


-Matthias

On 2/21/23 10:52 AM, SpacRocket wrote:
Hello Everyone,

I’d like to get a discussion going for KIP-907:
KIP-907: Add Boolean Serde to public interface - Apache Kafka - Apache Software Foundation <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface> cwiki.apache.org <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface> favicon.ico <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>

<https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
Which adds Boolean Serde to the public interface.

The KIP contains the details how I want to do this and what internal code I need to change.

Looking forward to the group’s feedback! :)

Kind regards
Jakub

Reply via email to