[
https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-1550:
----------------------------
Description:
1) kafka-patch-review.py uses git-diff to generate patch for jira ticket. The
resulting patch includes local uncommitted changes and is therefore different
from the patch published to reviewboard.
2) kafka-patch-review.py updates the jira ticket with attaching patch even if
the reviewboard update fails
3) os.popen is deprecated. Use subprocess.popen instead.
was:
1) kafka-patch-review.py uses git-diff to generate patch for jira ticket. The
resulting patch includes local uncommitted changes and is therefore different
from the patch published to reviewboard.
2) kafka-patch-review.py updates the jira ticket with attaching patch even if
the reviewboard update fails
3) os.popen is deprecated. Use subprocess.popen instead and
> Patch review tool should use git format-patch to generate patch
> ---------------------------------------------------------------
>
> Key: KAFKA-1550
> URL: https://issues.apache.org/jira/browse/KAFKA-1550
> Project: Kafka
> Issue Type: Bug
> Reporter: Dong Lin
> Assignee: Dong Lin
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> 1) kafka-patch-review.py uses git-diff to generate patch for jira ticket. The
> resulting patch includes local uncommitted changes and is therefore different
> from the patch published to reviewboard.
> 2) kafka-patch-review.py updates the jira ticket with attaching patch even if
> the reviewboard update fails
> 3) os.popen is deprecated. Use subprocess.popen instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
