Seems I am late to the party... Great KIP. Couple of questions from my side:

(1) What is the purpose of `standby-updating-tasks`? It seems to be the same as the number of assigned standby task? Not sure how useful it would be?


(2) `active-paused-tasks` / `standby-paused-tasks` -- what does "paused" exactly mean? There was a discussion about renaming the callback method from pause to suspended. So should this be called `suspended`, too? And if yes, how is it useful for users?


(3) `restore-ratio`: the description says

The fraction of time the thread spent on restoring active or standby tasks

I find the term "restoring" does only apply to active tasks, but not to standbys. Can we reword this?


(4) `restore-call-rate`: not sure what you exactly mean by "restore calls"?


(5) `restore-remaining-records-total` -- why is this a task metric? Seems we could roll it up into a thread metric that we report at INFO level (we could still have per-task DEBUG level metric for it in addition).


(6) What about "warmup tasks"? Internally, we treat them as standbys, but it seems it's hard for users to reason about it in the scale-out warm-up case. Would it be helpful (and possible) to report "warmup progress" explicitly?


-Matthias


On 11/1/22 2:44 AM, Lucas Brutschy wrote:
We need this!

+ 1 non binding

Cheers,
Lucas

On Tue, Nov 1, 2022 at 10:01 AM Bruno Cadonna <cado...@apache.org> wrote:

Guozhang,

Thanks for the KIP!

+1 (binding)

Best,
Bruno

On 25.10.22 22:07, Walker Carlson wrote:
+1 non binding

Thanks for the kip!

On Thu, Oct 20, 2022 at 10:25 PM John Roesler <vvcep...@apache.org> wrote:

Thanks for the KIP, Guozhang!

I'm +1 (binding)

-John

On Wed, Oct 12, 2022, at 16:36, Nick Telford wrote:
Can't wait!
+1 (non-binding)

On Wed, 12 Oct 2022, 18:02 Guozhang Wang, <guozhang.wang...@gmail.com>
wrote:

Hello all,

I'd like to start a vote for the following KIP, aiming to improve Kafka
Stream's restoration visibility via new metrics and callback methods:



https://cwiki.apache.org/confluence/display/KAFKA/KIP-869%3A+Improve+Streams+State+Restoration+Visibility


Thanks!
-- Guozhang



Reply via email to