Divij Vaidya created KAFKA-14414: ------------------------------------ Summary: Remove unnecessary usage of ObjectSerializationCache Key: KAFKA-14414 URL: https://issues.apache.org/jira/browse/KAFKA-14414 Project: Kafka Issue Type: Improvement Components: core Reporter: Divij Vaidya Fix For: 3.4.0 Attachments: Screenshot 2022-11-21 at 19.23.53.png
We create an instance of ObjectSerializationCache at [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/network/RequestChannel.scala#L113] which does not get used at all. We always "add" to the cache but never retrieve from it (as is evident by the fact that we don't store the reference of the cache anywhere). Adding information to the cache is expensive because it uses System.identityHashCode(Object) which is expensive as demonstrated by the flame graph of producer requests over Apache Kafka 3.3.1 plaintext broker. {{!Screenshot 2022-11-21 at 19.23.53.png!}} -- This message was sent by Atlassian Jira (v8.20.10#820010)