Hi Rajini, If I understand correctly, the client.rack config would stay supported after KIP-848 but does it expand the scope of that KIP too with this config? I mean that currently you propose ConsumerProtocolSubscription to be used but this protocol won't be available and we need to transfer the config to the coordinator via other means. Should this be added to that KIP?
Thanks, Viktor On Wed, Nov 2, 2022 at 9:50 PM Rajini Sivaram <rajinisiva...@gmail.com> wrote: > Hi Jun, > > Thank you for the review. Yes, we should add rack id to Subscription, had > missed that part. Updated the KIP, thank you for pointing that out! > > Regards, > > Rajini > > On Wed, Nov 2, 2022 at 7:06 PM Jun Rao <j...@confluent.io.invalid> wrote: > > > Hi, Rajini, > > > > Thanks for the KIP. Just one comment. > > > > Should we add rackId to GroupSubscription.Subscription for each member? > > > > Thanks, > > > > Jun > > > > On Wed, Nov 2, 2022 at 4:57 AM Rajini Sivaram <rajinisiva...@gmail.com> > > wrote: > > > > > Hi all, > > > > > > I have submitted KIP-881 to implement rack-aware partition assignment > for > > > consumers: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-881%3A+Rack-aware+Partition+Assignment+for+Kafka+Consumers > > > . > > > It adds rack id to the consumer group protocol to propagate rack > > > information so that rack-aware assignors can be added to benefit from > > > locality. > > > > > > Feedback and suggestions are welcome! > > > > > > Thank you, > > > > > > Rajini > > > > > >
