Thanks everybody! This KIP has passed with 3 binding votes (Luke, David, Colin).
Colin, I agree with the nitpick and have extended the KIP to mention throwing an informative error message. On Wed, Sep 7, 2022 at 11:09 PM Colin McCabe <cmcc...@apache.org> wrote: > +1 (binding). > > One nitpick: when the user sets AllowReplicationFactorChange = false, the > exception the user gets back from AdminClient should mention that this was > the problem. If the exception just says "The broker does not support > ALTER_PARTITION_REASSIGNMENTS with version in range [1, 1]. The supported > range is [0, 0]." the user will be confused about what the problem is. > Instead, the exception should mention that the broker does not support > AllowReplicationFactorChange. > > best, > Colin > > > On Wed, Sep 7, 2022, at 06:11, David Jacot wrote: > > +1 from me. Thanks, Stan! > > > > On Tue, Aug 23, 2022 at 12:10 PM Luke Chen <show...@gmail.com> wrote: > >> > >> Hi Stanislav, > >> > >> Thanks for the KIP. > >> The solution looks reasonable to me. > >> +1 from me. > >> > >> Thank you. > >> Luke > >> > >> On Tue, Aug 23, 2022 at 6:07 AM Stanislav Kozlovski > >> <stanis...@confluent.io.invalid> wrote: > >> > >> > Hello, > >> > > >> > I'd like to start a vote on KIP-860, which adds a client-provided > option to > >> > the AlterPartitionReassignmentsRequest that allows the user to guard > >> > against an unintentional change in the replication factor during > partition > >> > reassignments. > >> > > >> > Discuss Thread: > >> > https://lists.apache.org/thread/bhrqjd4vb05xtztkdo8py374m9dgq69r > >> > KIP: > >> > > >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-860%3A+Add+client-provided+option+to+guard+against+replication+factor+change+during+partition+reassignments > >> > JIRA: https://issues.apache.org/jira/browse/KAFKA-14121 > >> > > >> > > >> > -- > >> > Best, > >> > Stanislav > >> > > -- Best, Stanislav
