----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23474/#review47884 -----------------------------------------------------------
core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/23474/#comment84115> It seems that we can just feed all partitions to do the maybeShrinkIsr() check. That function already checks the leader info. Then, we can get rid of leaderParitionsLock. - Jun Rao On July 15, 2014, 1:18 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23474/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 1:18 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1483 > https://issues.apache.org/jira/browse/KAFKA-1483 > > > Repository: kafka > > > Description > ------- > > KAFKA-1483. Split Brain about Leader Partitions. > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 6a56a772c134dbf1e70c1bfe067223009bfdbac8 > > Diff: https://reviews.apache.org/r/23474/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
