(hit send too soon) KIP -- https://cwiki.apache.org/confluence/display/KAFKA/KIP-859%3A+Add+Metadata+Log+Processing+Error+Related+Metrics JIRA -- https://issues.apache.org/jira/browse/KAFKA-14114
On Thu, Aug 4, 2022 at 2:33 PM Niket Goel <ng...@confluent.io> wrote: > Hey Jose, > > I would like to request adding KIP-859 [1] to the 3.3.0 release. The KIP > adds some important metrics to allow visibility into KRaft log processing > related errors. > The KIP was approved today and I have a PR ready for review, which I hope > should get reviewed and merged within next week. > > Thanks > Niket Goel > > On Thu, Aug 4, 2022 at 8:58 AM José Armando García Sancio > <jsan...@confluent.io.invalid> wrote: > >> On Thu, Aug 4, 2022 at 8:37 AM Justine Olshan >> <jols...@confluent.io.invalid> wrote: >> > >> > Hey Jose. >> > I found a gap in handling ISR changes in ZK mode. We just need to >> prevent >> > brokers that are offline from being added to ISR. Since KIP-841 is part >> of >> > this release and the fix should be small (a few lines), I propose adding >> > https://issues.apache.org/jira/browse/KAFKA-14140 to the 3.3 release. >> > I'm hoping to have the PR reviewed and completed next week. >> >> I think we should include this fix in 3.3.0 for ZK mode. We >> implemented this fix for KRaft mode and it will make Apache Kafka >> safer when handling broker shutdowns. >> >> Thanks for volunteering to fix this. >> -- >> -José >> > > > -- > - Niket > -- - Niket