tombentley commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923438915
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item"
role="menuitem">
+ <a href="#"
class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false"
aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu"
aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/";
target="_blank">
+ Apache
Homepage
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/licenses/";>
+ License
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1"
href="https://www.apache.org/events/current-event";>
+ Events
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1"
href="https://www.apache.org/foundation/sponsorship.html"; target="_blank">
+
Sponsorship
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1"
href="https://www.apache.org/foundation/thanks.html";>
+ Sponsors
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/security/";>
Review Comment:
The Apache policy allows to link to a project specific page, and we already
have this at https://kafka.apache.org/project-security. I think using that
would be better that linking to the overarching Apache security page.
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item"
role="menuitem">
+ <a href="#"
class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false"
aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu"
aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/";
target="_blank">
+ Apache
Homepage
Review Comment:
The policy says
> This may either be a featured link in your main navigation system or a
text link in your Main homepage text. A best practice is to include a short
sentence or paragraph on the homepage noting that this project is an Apache
project, and is part of a larger community of developers and users.
So making the 'Apache' part of the homepage a link, and including this
information further down (after the "Trust and Ease of Use" section) should
also be acceptable, and indeed closer to the best practice.
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
