Hi Ismael, That's the plan. I just noticed that I forgot to change the version of the field in the AlterPartitionResponse. Let me fix that.
Thanks, David On Wed, Jun 1, 2022 at 10:40 AM Ismael Juma <ism...@juma.me.uk> wrote: > > Hi David, > > If you are adding topic IDs, should we remove topic names? > > Ismael > > On Tue, May 31, 2022, 6:36 AM David Jacot <dja...@confluent.io.invalid> > wrote: > > > Hi all, > > > > Thanks for your feedback. > > > > I just updated the KIP as follows: > > * I propose to add a `TopicId` field at the same time while we are bumping > > the AlterPartition API version. > > * I propose to add the `InShuttingDown` field to the registration records > > to > > track if a broker is in controlled shutdown. This is useful for debugging > > and > > it would also prevent unnecessary AlterPartition requests from getting sent > > to the controller by the leaders. This will also help for KAFKA-13944. > > > > Artem - That's a good question. As explained by Colin we don't have this > > notion of fenced replicas in the ZK world. > > > > José - That's right. I have updated that section as you suggested. > > > > Best, > > David > > > > On Tue, May 24, 2022 at 5:39 PM José Armando García Sancio > > <jsan...@confluent.io.invalid> wrote: > > > > > > Hi David, > > > > > > Thanks for the KIP. In the "Compatibility, Deprecation, and Migration > > > Plan", you have: > > > > > > > The change is backward compatible. > > > > > > I assume that we don't need to increase the metadata.version/IBP for > > > AlterPartition because AlterPartitionManager uses ApiVersions for that > > > channel. Should we mention that in that section? > > > > > > -- > > > -José > >
