Thanks for the KIP, this is a good improvement. I only have one minor suggestion.
Currently many command line tools supports config file argument, but their name style is not unified, for example, most newly added tools are using --command-config, but ConsoleConsumer use —consumer.config。 I think we should unify the naming style from now on, I recommend us to use --reader-config and --formatter-config for the newly added arguments. -- Best, Ziming > On May 26, 2022, at 4:36 PM, Alexandre Garnier <zig...@gmail.com> wrote: > > Hello everyone, > > Any feedback on this KIP https://cwiki.apache.org/confluence/x/bBqhD? > It is a straightforward improvement without any impact on existing users, > so not much to discuss besides maybe the option name. > > -- > Alex > > > Le mer. 18 mai 2022 à 10:44, Alexandre Garnier <zig...@gmail.com> a écrit : > >> Hi everyone, >> >> I created a KIP to add a config file option of reader/formatter for >> kafka-console-(consumer|producer).sh tools. >> https://cwiki.apache.org/confluence/x/bBqhD >> >> Thanks for your feedback, >> -- >> Alex >>
