----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21938/#review47641 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/producer/ConsoleProducer.scala <https://reviews.apache.org/r/21938/#comment83759> There is some typos pre this patch: 1. than -> then 2. codec also includes "none". - Guozhang Wang On May 27, 2014, 7:28 p.m., James Oliver wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21938/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 7:28 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1471 > https://issues.apache.org/jira/browse/KAFKA-1471 > > > Repository: kafka > > > Description > ------- > > Add producer unit tests for LZ4 and LZ4HC compression codecs > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > bc4074ec841650eff48dd8aafc1e6c712d8eae7d > clients/src/main/java/org/apache/kafka/common/record/Compressor.java > 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 > core/src/main/scala/kafka/producer/ConsoleProducer.scala > a2af988d99a94a20291d6a2dc9bec73197f1b756 > core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala > 17e2c6e9dfd789acb4b6db37c780c862667e4e11 > > Diff: https://reviews.apache.org/r/21938/diff/ > > > Testing > ------- > > > Thanks, > > James Oliver > >
