Thanks for addressing my comments Mickael. No more comments/suggestions from my side. LGTM.
Divij Vaidya On Tue, May 10, 2022 at 6:10 PM Mickael Maison <mickael.mai...@gmail.com> wrote: > Hi Colin, > > Thanks for the suggestion. > > I guess there are pros and cons with both methods. In my mind I'm > expecting these values to always be there in the long run (once people > have upgraded to brokers that support this feature). So I thought > having a primitive directly may be nicer to use in the future. On the > other hand OptionalLong avoids exposing magic values to users and > makes error cases (brokers that support the feature but hit an error) > a bit nicer. > > We seem to already be using Optional fields in a few *Result classes > so I'll follow your suggestion. As a bonus that also resolves the > naming questions from Divij! > > I've updated the KIP accordingly. > > Thanks, > Mickael > > On Wed, May 4, 2022 at 2:52 PM Igor Soarez <i...@soarez.me> wrote: > > > > Hi Mickael, > > > > Thanks for writing this KIP. This would be a very useful improvement! > > > > -- > > Igor > > > > On Thu, Apr 7, 2022, at 10:16 AM, Mickael Maison wrote: > > > Hi, > > > > > > I wrote a small KIP to expose the total and usable space of logdirs > > > via the DescribeLogDirs API: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-827%3A+Expose+logdirs+total+and+usable+space+via+Kafka+API > > > > > > Please take a look and let me know if you have any feedback. > > > > > > Thanks, > > > Mickael >
