qingwei91 commented on code in PR #410: URL: https://github.com/apache/kafka-site/pull/410#discussion_r872286879
########## start-preview.sh: ########## @@ -0,0 +1,9 @@ +#!/usr/bin/env bash + +set -euxo pipefail + +docker build -t kafka-site-preview . + +docker run -dit --rm --name mypreview -p 8080:80 -v "$PWD":/usr/local/apache2/htdocs/ kafka-site-preview + +echo "You can stop the preview server by running `docker stop mypreview`" Review Comment: Hi, thanks for the suggestion, I am not a shell expert so I might be missing something here, I think we achieve similar effect by not running the container in detached mode. Then ctrl + c will work, do you think that's acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
