Hi Mickael, +1 to add "test plan" section to KIP template. Thanks for the improvement!
Luke On Tue, May 10, 2022 at 11:21 PM Mickael Maison <mickael.mai...@gmail.com> wrote: > Hi, > > I did not see any comments nor concerns so I went ahead and added the > Test Plan section to the KIP template. > > Thanks, > Mickael > > On Fri, Apr 1, 2022 at 5:53 PM Mickael Maison <mickael.mai...@gmail.com> > wrote: > > > > Hi, > > > > Unearthing this old thread as today I stumbled on the issue that > > Ismael reported. It looks like this was never fixed! > > > > The "Test Plan" section was only added in the KIP-template page [0] > > and not in the actual KIP-template template [1] that is used when > > doing `Create -> KIP-Template` or by clicking on `Create KIP` on > > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals > > > > I think this new section makes sense and it's very easy to add it to > > the actual template. Before doing it, I just want to ping the dev list > > to see if anybody has suggestions or concerns since this was discussed > > many years ago now. > > > > 0: https://cwiki.apache.org/confluence/display/KAFKA/KIP-Template > > 1: > https://cwiki.apache.org/confluence/pages/templates2/viewpagetemplate.action?entityId=54329345&key=KAFKA > > > > Thanks, > > Mickael > > > > On Fri, May 27, 2016 at 10:55 AM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > Hi Gwen, > > > > > > Thanks for adding the "Test Plans" section. I think it may be worth > adding > > > a note about performance testing plans too (whenever relevant). By the > way, > > > even though the following page has the new section, if I use `Create -> > > > KIP-Template`, the new section doesn't appear. Do you know why? > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-Template > > > > > > Ismael > > > > > > On Fri, May 27, 2016 at 3:24 AM, Gwen Shapira <g...@confluent.io> > wrote: > > > > > > > Hi Kafka Developers, > > > > > > > > Just a quick heads-up that I added a new section to the KIP > template: "Test > > > > Plans". > > > > I think its a good habit to think about how a feature will be tested > while > > > > planning it. I'm talking about high-level notes on system tests, not > gritty > > > > details. > > > > > > > > This will apply to new KIPs, not ones in discussion/implementation > phases > > > > (although if your KIP is under discussion and you want to add test > plans, > > > > it will be very nice of you). > > > > > > > > I figured we all agree that thinking a bit about tests is a good > idea, so I > > > > added it first and started a discussion later. If you strongly > object, > > > > please respond with strong objections. Wikis are easy to edit :) > > > > > > > > Gwen > > > > >
