Hi Matthew, Thanks for submitting this KIP. This is a useful improvement. +1 non binding
Best, -- Igor On Fri, Apr 22, 2022, at 12:01 PM, Tom Bentley wrote: > Hi Matthew, > > Thanks for the KIP, +1 (binding). > > Kind regards, > > Tom > > On Thu, 14 Apr 2022 at 12:15, Matthew de Detrich > <matthew.dedetr...@aiven.io.invalid> wrote: > >> Hi David, >> >> Thanks for the response. >> >> > 1. In the public interface section, could we spell out >> the configurations that we are changing with this >> KIP? The name does not change but the semantic is >> so it is good to be clear. >> >> Done >> >> > 2. In the proposed changes section, I would rather >> mention the configuration that we need to change the >> validation for instead of saying "loosening the validation >> on listenerListToEndPoints in kafka.utils.CoreUtils.scala" >> as this is specific to the implementation. >> >> This is already done with examples later down in the same section, or am I >> missing something? Would you like me to just remove the >> kafka.utils.CoreUtils.scala reference so its not implying an implementation >> detail? >> >> > 3. For my understanding, using the same port with two >> different DNS entries would fail, right? e.g. >> "PLAINTEXT://foo:9092,PLAINTEXT://bar:9092" >> >> Correct, the idea is that it checks that the listener host is an IP address >> and if it's not then it doesn't even consider it (i.e. it short circuits to >> what is current behaviour). The proposed KIP changes only apply if >> hostnames in the listener are IP address's otherwise no change is >> observable. >> >> Regards >> >> On Mon, Feb 21, 2022 at 10:42 AM David Jacot <dja...@confluent.io.invalid> >> wrote: >> >> > Hi Matthew, >> > >> > Thanks for the KIP. I have a few minor comments: >> > >> > 1. In the public interface section, could we spell out >> > the configurations that we are changing with this >> > KIP? The name does not change but the semantic is >> > so it is good to be clear. >> > >> > 2. In the proposed changes section, I would rather >> > mention the configuration that we need to change the >> > validation for instead of saying "loosening the validation >> > on listenerListToEndPoints in kafka.utils.CoreUtils.scala" >> > as this is specific to the implementation. >> > >> > 3. For my understanding, using the same port with two >> > different DNS entries would fail, right? e.g. >> > "PLAINTEXT://foo:9092,PLAINTEXT://bar:9092" >> > >> > Best, >> > David >> > >> > On Fri, Feb 11, 2022 at 10:35 AM Luke Chen <show...@gmail.com> wrote: >> > > >> > > Hi Matthew, >> > > >> > > Thanks for the update. >> > > I'm +1 (binding) >> > > >> > > Thank you. >> > > Luke >> > > >> > > On Fri, Feb 11, 2022 at 3:32 PM Matthew de Detrich >> > > <matthew.dedetr...@aiven.io.invalid> wrote: >> > > >> > > > Hi Luke, >> > > > >> > > > I have just updated the KIP with the changes you requested. >> > > > >> > > > Regards >> > > > >> > > > On Fri, Feb 11, 2022 at 4:47 AM Luke Chen <show...@gmail.com> wrote: >> > > > >> > > > > Hi Matthew, >> > > > > >> > > > > I checked again the KIP, and it LGTM. >> > > > > >> > > > > Just a minor comment: >> > > > > Maybe add some examples into the KIP to show how users can set both >> > IPv4 >> > > > > and IPv6 on the same port. >> > > > > And some examples to show how the validation will fail like you >> > listed in >> > > > > `Proposed Changes`. >> > > > > >> > > > > Thank you. >> > > > > Luke >> > > > > >> > > > > >> > > > > On Fri, Feb 11, 2022 at 8:54 AM Matthew de Detrich >> > > > > <matthew.dedetr...@aiven.io.invalid> wrote: >> > > > > >> > > > > > Hello everyone >> > > > > > >> > > > > > I have just updated/rebased the PR against the latest Kafka >> trunk. >> > Let >> > > > me >> > > > > > know if anything else is required/missing. >> > > > > > >> > > > > > Regards >> > > > > > >> > > > > > On Thu, Jan 13, 2022 at 10:28 AM Matthew de Detrich < >> > > > > > matthew.dedetr...@aiven.io> wrote: >> > > > > > >> > > > > > > Does anyone have any additional comments/regards to help get >> > this PR >> > > > > > voted >> > > > > > > through? >> > > > > > > >> > > > > > > On Tue, Nov 23, 2021 at 7:46 AM Josep Prat >> > > > <josep.p...@aiven.io.invalid >> > > > > > >> > > > > > > wrote: >> > > > > > > >> > > > > > >> Hi Matthew, >> > > > > > >> >> > > > > > >> Thank you for the PR. >> > > > > > >> >> > > > > > >> +1 (non binding) from my side. >> > > > > > >> >> > > > > > >> >> > > > > > >> Best, >> > > > > > >> >> > > > > > >> ——— >> > > > > > >> Josep Prat >> > > > > > >> >> > > > > > >> Aiven Deutschland GmbH >> > > > > > >> >> > > > > > >> Immanuelkirchstraße 26, 10405 Berlin >> > > > > > >> >> > > > > > >> Amtsgericht Charlottenburg, HRB 209739 B >> > > > > > >> >> > > > > > >> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > > > > >> >> > > > > > >> m: +491715557497 >> > > > > > >> >> > > > > > >> w: aiven.io >> > > > > > >> >> > > > > > >> e: josep.p...@aiven.io >> > > > > > >> >> > > > > > >> On Tue, Nov 23, 2021, 07:11 Ivan Yurchenko < >> > > > ivan0yurche...@gmail.com> >> > > > > > >> wrote: >> > > > > > >> >> > > > > > >> > Hi, >> > > > > > >> > >> > > > > > >> > Thank you for the KIP. >> > > > > > >> > >> > > > > > >> > +1 (non-binding) >> > > > > > >> > >> > > > > > >> > Ivan >> > > > > > >> > >> > > > > > >> > >> > > > > > >> > On Tue, 23 Nov 2021 at 04:18, Luke Chen <show...@gmail.com> >> > > > wrote: >> > > > > > >> > >> > > > > > >> > > Hi Matthew, >> > > > > > >> > > Thanks for the KIP. >> > > > > > >> > > It makes sense to allow IPv4 and IPv6 listening on the >> same >> > port >> > > > > for >> > > > > > >> the >> > > > > > >> > > listener config. >> > > > > > >> > > >> > > > > > >> > > +1 (non-binding) >> > > > > > >> > > >> > > > > > >> > > Thank you. >> > > > > > >> > > Luke >> > > > > > >> > > >> > > > > > >> > > On Mon, Nov 22, 2021 at 6:28 PM Matthew de Detrich >> > > > > > >> > > <matthew.dedetr...@aiven.io.invalid> wrote: >> > > > > > >> > > >> > > > > > >> > > > Hello everyone, >> > > > > > >> > > > >> > > > > > >> > > > I would like to start a vote for KIP-797: Accept >> duplicate >> > > > > > listener >> > > > > > >> on >> > > > > > >> > > port >> > > > > > >> > > > for IPv4/IPv6 >> > > > > > >> > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > >> > >> > > > > > >> >> > > > > > >> > > > > >> > > > >> > >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195726330 >> > > > > > >> > > > >> > > > > > >> > > > The purpose of the KIP is to loosen current validation >> > for non >> > > > > > >> > advertised >> > > > > > >> > > > listeners so that you can have an IPv4 address and an >> IPv6 >> > > > > address >> > > > > > >> on >> > > > > > >> > the >> > > > > > >> > > > same port. All other behaviour remains the same as >> before >> > > > (since >> > > > > > >> these >> > > > > > >> > > are >> > > > > > >> > > > disparate IP stacks there are no technical reasons not >> to >> > > > allow >> > > > > > >> this). >> > > > > > >> > > > >> > > > > > >> > > > PR is located at >> > https://github.com/apache/kafka/pull/11478 >> > > > > > >> > > > >> > > > > > >> > > > Comments and feedback are welcome! >> > > > > > >> > > > >> > > > > > >> > > > Regards >> > > > > > >> > > > >> > > > > > >> > > > -- >> > > > > > >> > > > >> > > > > > >> > > > Matthew de Detrich >> > > > > > >> > > > >> > > > > > >> > > > *Aiven Deutschland GmbH* >> > > > > > >> > > > >> > > > > > >> > > > Immanuelkirchstraße 26, 10405 Berlin >> > > > > > >> > > > >> > > > > > >> > > > Amtsgericht Charlottenburg, HRB 209739 B >> > > > > > >> > > > >> > > > > > >> > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > > > > >> > > > >> > > > > > >> > > > *m:* +491603708037 >> > > > > > >> > > > >> > > > > > >> > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > >> > >> > > > > > >> >> > > > > > > >> > > > > > > >> > > > > > > -- >> > > > > > > >> > > > > > > Matthew de Detrich >> > > > > > > >> > > > > > > *Aiven Deutschland GmbH* >> > > > > > > >> > > > > > > Immanuelkirchstraße 26, 10405 Berlin >> > > > > > > >> > > > > > > Amtsgericht Charlottenburg, HRB 209739 B >> > > > > > > >> > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > > > > > >> > > > > > > *m:* +491603708037 >> > > > > > > >> > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io >> > > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > >> > > > > > Matthew de Detrich >> > > > > > >> > > > > > *Aiven Deutschland GmbH* >> > > > > > >> > > > > > Immanuelkirchstraße 26, 10405 Berlin >> > > > > > >> > > > > > Amtsgericht Charlottenburg, HRB 209739 B >> > > > > > >> > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > > > > >> > > > > > *m:* +491603708037 >> > > > > > >> > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io >> > > > > > >> > > > > >> > > > >> > > > >> > > > -- >> > > > >> > > > Matthew de Detrich >> > > > >> > > > *Aiven Deutschland GmbH* >> > > > >> > > > Immanuelkirchstraße 26, 10405 Berlin >> > > > >> > > > Amtsgericht Charlottenburg, HRB 209739 B >> > > > >> > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > > > >> > > > *m:* +491603708037 >> > > > >> > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io >> > > > >> > >> >> >> -- >> >> Matthew de Detrich >> >> *Aiven Deutschland GmbH* >> >> Immanuelkirchstraße 26, 10405 Berlin >> >> Amtsgericht Charlottenburg, HRB 209739 B >> >> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> >> *m:* +491603708037 >> >> *w:* aiven.io *e:* matthew.dedetr...@aiven.io >>
