Hi Mickael, I think Federico is suggesting that we would do this in AK 4.0 and hence the breaking change (with the appropriate deprecation period) would be possible. I personally prefer that option too. Is there an urgent need to do this before 4.0?
Ismael On Mon, May 2, 2022 at 8:58 AM Mickael Maison <mickael.mai...@gmail.com> wrote: > HI Federico, > > Thanks for taking a look. > > I think the method you suggest is what I included in the rejected > alternatives section. The reason I rejected it is because it would > force people to change their configuration in order to preserve the > current behavior, hence a breaking change. > > Thanks, > Mickael > > On Fri, Apr 22, 2022 at 6:26 PM Federico Valeri <fedeval...@gmail.com> > wrote: > > > > Hi Mickael, what about setting the default value to JmxReporter while > > also maintaining the old behavior? When a user is setting > > metric.reporters without explicitly including the JmxReporter, we > > could simply print a warning message which says "The automatic > > addition of the JmxReporter is deprecated. Add it explicitly to the > > metric.reporters list if needed.", or something like that. That way we > > can avoid adding a new property, and drop the implicit setting in the > > next major release. > > > > On Wed, Apr 13, 2022 at 11:49 AM Mickael Maison > > <mickael.mai...@gmail.com> wrote: > > > > > > Hi, > > > > > > I've created a small KIP to allow disabling JMXreporter: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter > > > > > > Let me know if you have any feedback. > > > > > > Thanks, > > > Mickael >
