Hi James, Sorry for the late reply.
Yes, this is a good point, to know how many segments to be recovered if there are some large partitions. I've updated the KIP, to add a `*RemainingSegmentsToRecover*` metric for each log recovery thread, to show the value. The example in the Proposed section here <https://cwiki.apache.org/confluence/display/KAFKA/KIP-831%3A+Add+metric+for+log+recovery+progress#KIP831:Addmetricforlogrecoveryprogress-ProposedChanges> shows what it will look like. Thanks for the suggestion. Thank you. Luke On Sat, Apr 23, 2022 at 8:54 AM James Cheng <wushuja...@gmail.com> wrote: > The KIP describes RemainingLogsToRecovery, which seems to be the number of > partitions in each log.dir. > > We have some partitions which are much much larger than others. Those > large partitions have many many more segments than others. > > Is there a way the metric can reflect partition size? Could it be > RemainingSegmentsToRecover? Or even RemainingBytesToRecover? > > -James > > Sent from my iPhone > > > On Apr 20, 2022, at 2:01 AM, Luke Chen <show...@gmail.com> wrote: > > > > Hi all, > > > > I'd like to propose a KIP to expose a metric for log recovery progress. > > This metric would let the admins have a way to monitor the log recovery > > progress. > > Details can be found here: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-831%3A+Add+metric+for+log+recovery+progress > > > > Any feedback is appreciated. > > > > Thank you. > > Luke >
