Hi All, Can someone review and merge below PR? It's a small change. I also added unit test cases to cover different scenarios.
Issue: https://issues.apache.org/jira/browse/KAFKA-12380 PR: https://github.com/apache/kafka/pull/11955 Thanks, ~ Rajani On Thu, Mar 31, 2022 at 11:45 PM Rajani Karuturi <raj...@apache.org> wrote: > Tests failed again. :( > > Is everyone facing this problem? > > I tried to look at the cause for the test failures but couldn’t find any. > > Is it possible to review and merge this? > It’s a pretty small fix. > > Thanks, > > > On Thu, 31 Mar 2022 at 8:24 PM, Adam Bellemare <adam.bellem...@gmail.com> > wrote: > >> Thanks Bruno :) >> >> On Thu, Mar 31, 2022 at 10:09 AM Bruno Cadonna <cado...@apache.org> >> wrote: >> >> > Hi Rajani and Adam, >> > >> > I do not think "retest this" or any other comment works for >> > non-committers anymore. >> > >> > Rajani, the failures seem to be flaky tests since they are unrelated to >> > your change. Could you please look into JIRA for the flaky tests? You >> > should find tickets that start with "Flaky test" or similar. If you find >> > tickets, comment on the tickets that the test failed again. I think you >> > will find other comments that you can use as an example. >> > >> > I restarted the builds. >> > >> > Best, >> > Bruno >> > >> > On 31.03.22 15:51, Adam Bellemare wrote: >> > > It could be an intermittent error. I think there is a way to issue a >> > retest >> > > via a comment in github ("retest this") but I am not sure if that's >> the >> > > precise command, nor if you will have the ability to kick it off. >> > > >> > > >> > > >> > > On Thu, Mar 31, 2022 at 9:12 AM Rajani Karuturi <raj...@apache.org> >> > wrote: >> > > >> > >> Hi All, >> > >> I am new here. To get started, I took one of the "newbie" issues and >> > made >> > >> changes for the same. >> > >> >> > >> Issue: https://issues.apache.org/jira/browse/KAFKA-12380 >> > >> PR: https://github.com/apache/kafka/pull/11955 >> > >> >> > >> PR build shows some test failures but the same pass on my local. >> > >> The change is very isolated and should not cause any failures >> ideally. >> > >> Can someone please help me on the next steps? >> > >> >> > >> Thanks, >> > >> ~ Rajani >> > >> >> > > >> > >> > -- > ~ Rajani >
